Adapt to some skill and tool changes the system made, fixing #60 #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Way back in dnd5e 2.2.0, they moved tool checks from the item to the actor. When doing so, the
dnd5e.preRollToolCheck
hook changed its arguments. Now we can get thetoolId
but Midi hasn't defined any new flags that use that so I'm not going to add it here. But it does now pass the ability used inconfig.data.defaultAbility
so I don't need to look it up on the actor. It also honors the ability they may have passed in as an argument to therollToolCheck
function.While here, I noticed skills use the same
config.data.defaultAbility
which also honors the ability that is passed intorollSkill
. While an edge case, it could come up more often now that the enrichers exist to prompt for skill checks where you can specify the ability as well.