Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to some skill and tool changes the system made, fixing #60 #61

Merged
merged 3 commits into from
Feb 24, 2024

Conversation

kaelad02
Copy link
Owner

Way back in dnd5e 2.2.0, they moved tool checks from the item to the actor. When doing so, the dnd5e.preRollToolCheck hook changed its arguments. Now we can get the toolId but Midi hasn't defined any new flags that use that so I'm not going to add it here. But it does now pass the ability used in config.data.defaultAbility so I don't need to look it up on the actor. It also honors the ability they may have passed in as an argument to the rollToolCheck function.

While here, I noticed skills use the same config.data.defaultAbility which also honors the ability that is passed into rollSkill. While an edge case, it could come up more often now that the enrichers exist to prompt for skill checks where you can specify the ability as well.

@kaelad02 kaelad02 merged commit ab7fe34 into main Feb 24, 2024
1 check passed
@kaelad02 kaelad02 deleted the fix60 branch February 24, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant