Merge pull request #135 from joegoldbeck/master

Throw error when path doesn't begin with a leading slash
kadirahq · Sep 9, 2015 · 05a2699 · 05a2699
2 parents 77c7b69 + 5e09b1c
commit 05a2699
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/server/routes.js b/lib/server/routes.js
@@ -12,6 +12,9 @@ fastRenderRoutes.middleware(function(req, res, next) {
 
 // handling specific routes
 FastRender.route = function route(path, callback) {
+  if(path.indexOf('/') !== 0){
+    throw new Error('Error: path (' + path + ') must begin with a leading slash "/"')
+  }
   fastRenderRoutes.route(path, FastRender.handleRoute.bind(null, callback));
 };
 

diff --git a/tests/server/integration.js b/tests/server/integration.js
@@ -187,6 +187,15 @@ Tinytest.add('integration - error inside a null publication', function(test) {
   test.equal(data.collectionData, {});
 });
 
+Tinytest.add('integration - when path has no leading slash', function(test) {
+  var path = Random.id();
+
+  test.throws(function(){
+    FastRender.route(path, function() {
+    });
+  }, 'Error: path (' + path + ') must begin with a leading slash "/"');
+});
+
 var urlResolve = Npm.require('url').resolve;
 function getFRData(path) {
   var url = urlResolve(process.env.ROOT_URL, path);