Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix location for span infos, report better error locations in repl #284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix location for span infos, report better error locations in repl #284

wants to merge 1 commit into from

Conversation

jmcardon
Copy link
Member

@jmcardon jmcardon commented Nov 22, 2024 •
edited
Loading

Closes #262

Using the example in #262:

Before this PR:

pact>(load "scratch/main-script.repl" true)
"Loading scratch/main-script.repl..."
"Loading nested-script.repl..."
Loaded repl defun just-fail
scratch/main-script.repl:12:2: We fail
 12 | ; Hello
    |   ^^^^^^^^^^^^^^^^^^^^^^^^^
  at (#repl.just-fail.{I3JlcGw})

After this PR:

pact>(load "scratch/main-script.repl" true)
"Loading scratch/main-script.repl..."
"Loading nested-script.repl..."
Loaded repl defun just-fail
()
scratch/nested-script.repl:12:2: We fail
 12 |   (enforce false "We fail")
    |   ^^^^^^^^^^^^^^^^^^^^^^^^^
  at(#repl.just-fail.{I3JlcGw}):scratch/main-script.repl 2:0-2:11

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • (If Relevant) Documentation has been (manually) updated at https://docs.kadena.io/pact

Additionally, please justify why you should or should not do the following:

  • Benchmark regressions
  • Confirm replay/back compat (Ignore until core release)
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact (Ignore until core release)

@jmcardon jmcardon marked this pull request as draft November 22, 2024 20:57
@jmcardon jmcardon changed the title Fix location for span infos Fix location for span infos, report better error locations in repl Nov 22, 2024
@jmcardon jmcardon force-pushed the jose/repl-file-infos branch 2 times, most recently from a3362e2 to 4db664c Compare November 25, 2024 19:23
@jmcardon jmcardon marked this pull request as ready for review December 2, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwiegley jwiegley Awaiting requested review from jwiegley jwiegley is a code owner

@emilypi emilypi Awaiting requested review from emilypi emilypi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong error location when several files in scope.
1 participant
@jmcardon