[pact integration] bloom filter cache for pact txs in blocks #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not using it yet -- in the next changeset we will leverage the bloom cache to short-circuit tx lookup during `/poll` and `/listen`.
mightybyte
approved these changes
Mar 19, 2019
Closed
chessai
pushed a commit
that referenced
this pull request
Jun 27, 2024
* Initial go at delete range support * Configuration foibles * Default options for withTempRocksDb * FFI x 2 * Hm * Add compact range * Allow omitting range bounds * Try to fix Mac build * Modern default settings for RocksDB maxOpenFiles = -1 writeBufferSize = 64MB * Make compaction safe * Use unsafePackCStringFinalizer in get * Add extra build requirements to README * Use more unsafeUseAsCStringLen
chessai
pushed a commit
that referenced
this pull request
Jun 27, 2024
We can't control what C compiler the user has available, and `-Werror` effectively makes forward compatibility impossible. This is probably fixed in a newer RocksDB, but we haven't updated, so for now just live with what we have.
chessai
pushed a commit
that referenced
this pull request
Aug 6, 2024
We can't control what C compiler the user has available, and `-Werror` effectively makes forward compatibility impossible. This is probably fixed in a newer RocksDB, but we haven't updated, so for now just live with what we have.
chessai
pushed a commit
that referenced
this pull request
Aug 6, 2024
* Initial go at delete range support * Configuration foibles * Default options for withTempRocksDb * FFI x 2 * Hm * Add compact range * Allow omitting range bounds * Try to fix Mac build * Modern default settings for RocksDB maxOpenFiles = -1 writeBufferSize = 64MB * Make compaction safe * Use unsafePackCStringFinalizer in get * Add extra build requirements to README * Use more unsafeUseAsCStringLen
chessai
pushed a commit
that referenced
this pull request
Aug 6, 2024
We can't control what C compiler the user has available, and `-Werror` effectively makes forward compatibility impossible. This is probably fixed in a newer RocksDB, but we haven't updated, so for now just live with what we have.
chessai
pushed a commit
that referenced
this pull request
Aug 6, 2024
* Initial go at delete range support * Configuration foibles * Default options for withTempRocksDb * FFI x 2 * Hm * Add compact range * Allow omitting range bounds * Try to fix Mac build * Modern default settings for RocksDB maxOpenFiles = -1 writeBufferSize = 64MB * Make compaction safe * Use unsafePackCStringFinalizer in get * Add extra build requirements to README * Use more unsafeUseAsCStringLen
chessai
pushed a commit
that referenced
this pull request
Nov 13, 2024
We can't control what C compiler the user has available, and `-Werror` effectively makes forward compatibility impossible. This is probably fixed in a newer RocksDB, but we haven't updated, so for now just live with what we have.
chessai
pushed a commit
that referenced
this pull request
Dec 10, 2024
* Initial go at delete range support * Configuration foibles * Default options for withTempRocksDb * FFI x 2 * Hm * Add compact range * Allow omitting range bounds * Try to fix Mac build * Modern default settings for RocksDB maxOpenFiles = -1 writeBufferSize = 64MB * Make compaction safe * Use unsafePackCStringFinalizer in get * Add extra build requirements to README * Use more unsafeUseAsCStringLen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of pact
/polland/lookupare going to be really expensive. If we precompute a bloom filter for pact txs at each block we can skip lookup + decode for most blocks.