Ensure that RTE metrics are served securely with kube-rbac-proxy #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swatisehgal
force-pushed
the
rte-serve-metrics-securely
branch
3 times, most recently
from
c2f991a to
8693c8d
Compare
|
/test e2e-metrics-https |
|
Hmm, this is strange. |
swatisehgal
force-pushed
the
rte-serve-metrics-securely
branch
from
8693c8d to
09e9374
Compare
swatisehgal
force-pushed
the
rte-serve-metrics-securely
branch
from
09e9374 to
629c9ec
Compare
Signed-off-by: Swati Sehgal <[email protected]>
swatisehgal
force-pushed
the
rte-serve-metrics-securely
branch
from
629c9ec to
7b3b63a
Compare
|
/close Kube-rbac-proxy was considered a suitable way to expose metrics over https for the ease of backportability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Kube-rbac-proxy side car container to RTE daemonset to ensure that RTE metrics are served securely.
Reference doc: https://rhobs-handbook.netlify.app/products/openshiftmonitoring/collecting_metrics.md/