config: prepare for introducing config file handling #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we were abusing objects to hold global settings. It's time to start cleaning up, so we move globals in their own object, and start adding p;roper JSON annotation. internal-only change. Signed-off-by: Francesco Romani <[email protected]>
move configfile processing in its own file, to be expanded later. Internal-only change. Signed-off-by: Francesco Romani <[email protected]>
Split the handling of defaults value from flags processing _and_ from the environment variables processing. Unfortunately is quite hard to de-entangle the mess with incremental steps so we bite the bullet and we cut the (albeit little) gordian knot with a single swing in this change. Move environment variables override in their own file, and move the defaults processing in its own function, so the flags can now trivially only bind parameter names to values. Minimal and expected harmless user-visible changes (due to different flow, unavoidable, only in hostname processing). Otherwise internal-only change. Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
config-redo-prep
branch
from
66e21b2 to
4641b04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is cleanup and prep work for #111.
These are value-adding cleanups that can be merged early and that are expected to have no user-visible changes except for the hostname default value, which should be harmless anyway.
All in all, mostly internal refactoring.