podres: client: make independent of k8s code #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffromani
force-pushed
the
independent-podres-cli
branch
2 times, most recently
from
92d5044 to
2ded56d
Compare
ffromani
force-pushed
the
independent-podres-cli
branch
from
2ded56d to
271dd40
Compare
It's actively discouraged by k8s project to import `k8s.io/kubernetes` packages, and, in addition to this, it's recommended (https://github.com/kubernetes/kubernetes/blob/v1.28.0-rc.0/pkg/kubelet/apis/podresources/client.go#L32) to reimplement the client in each consuming project, copying and pasting the related functions. We missed this recommentation up until now, so we do it now. This way, we can remove the latest dep to `k8s.io/kubernetes`, have less deps overall and a leaner `vendor/`. Signed-off-by: Francesco Romani <[email protected]>
classic `go mod tidy && go mod vendor` run Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
independent-podres-cli
branch
from
271dd40 to
9072547
Compare
ffromani
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's actively discouraged by k8s project to import
k8s.io/kubernetespackages, and, in addition to this, it's recommended (https://github.com/kubernetes/kubernetes/blob/v1.28.0-rc.0/pkg/kubelet/apis/podresources/client.go#L32)
to reimplement the client in each consuming project, copying and pasting the related functions.
We missed this recommentation up until now, so we do it now.
This way, we can remove the latest dep to
k8s.io/kubernetes,have less deps overall and a leaner
vendor/.