WIP: overhaul the config management #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffromani
force-pushed
the
redo-config
branch
from
8df2598 to
d9557c4
Compare
Separate bump (go mod tidy + go mod vendor) to make the followup change leaner. Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
redo-config
branch
from
d9557c4 to
2ac2f46
Compare
Leveraging the 3rd party koanf package, we can achieve a longstanding goal for RTE: really useful configuration file handling, AND 1:1 mapping between the configuration file and the command line flags. This mean we can have: 1. hardcoded defaults. 2. a configuration file, which can override any hardcoded default 3. the commandline flags, which can override defaults and take precedence over the configuration file settings. This allow to greatly reduce the overabundance of commandline flags, and allow shipping configuration file to simplify the deployment. Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
redo-config
branch
from
2ac2f46 to
dbd529a
Compare
|
we will resume once we have capacity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leveraging the the koanf package, we can achieve a longstanding goal for RTE: really useful configuration file handling, AND 1:1 mapping between the configuration file and the command line flags.
This mean we can have:
precedence over the configuration file settings.
This allow to greatly reduce the overabundance of commandline flags, and allow shipping configuration file to simplify the deployment.
TBD: need to improve the unit and e2e test coverage
Fixes: #111