rte: add option to compute the pod set fingerprint #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
ffromani
force-pushed
the
node-signature
branch
11 times, most recently
from
9439d09 to
396ec54
Compare
|
/unhold |
|
e2e tests are currently broken, I'll investigate and fix them |
ffromani
force-pushed
the
node-signature
branch
2 times, most recently
from
69f0a6b to
fc2c735
Compare
should be fixed now. PR ready. |
ffromani
force-pushed
the
node-signature
branch
2 times, most recently
from
a68bf16 to
b3a022a
Compare
Tal-or
reviewed
Jun 14, 2022
Add an option to compute the fingerprint of the current pod set, and report it as annotation to NRT objects. This is meant to enable better caching in the scheduler side. Signed-off-by: Francesco Romani <[email protected]>
Add a trivial package to consolidate the annotations. We are adding more of them, scattered all across packages. Moving all the definitions in a single place, we can make it easier to consume. Signed-off-by: Francesco Romani <[email protected]>
This is meant to help clients, most notable e2e tests. We expose this information as annotation (and not as status field) mostly because this is status/metadata of the updater agent, not of the NRT object proper. Signed-off-by: Francesco Romani <[email protected]>
add basic e2e tests for the fingerprinting functionality: - PFP should be stable with no pod churn - PFP MUST change if we add or delete pods Signed-off-by: Francesco Romani <[email protected]>
Make sure we always report meaningful data. Most notable, 1 second granularity is sufficient for all the expected use cases (e2e tests) In general, if the update period is less than 1 second, the configuration is very suspicious anyway. Signed-off-by: Francesco Romani <[email protected]>
swatisehgal
reviewed
Jun 15, 2022
explain all the failure conditions when validating NRT objects. Signed-off-by: Francesco Romani <[email protected]>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to compute the fingerprint of the current pod set, and report it as annotation to NRT objects. This is meant to enable better caching in the scheduler side.
Signed-off-by: Francesco Romani [email protected]