-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
metrics: overhaul, extract server package
overhaul the metrics package, renaming it from `prometheus` (even though the impl will be prometheus based with no plans to change it) and extract the server package, which will be augmented to support the TLS serving later on Signed-off-by: Francesco Romani <[email protected]>
- Loading branch information
Showing
10 changed files
with
257 additions
and
91 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| /* | ||
| Copyright 2023 The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package metrics | ||
|
|
||
| import ( | ||
| "os" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestSetup(t *testing.T) { | ||
| type testCase struct { | ||
| name string | ||
| arg string | ||
| env string | ||
| expected string | ||
| } | ||
|
|
||
| for _, tcase := range []testCase{ | ||
| { | ||
| name: "all empty", | ||
| expected: mustHostname(), | ||
| }, | ||
| { | ||
| name: "from arg", | ||
| arg: "arg.localtest.it", | ||
| expected: "arg.localtest.it", | ||
| }, | ||
| { | ||
| name: "from env", | ||
| env: "env.localtest.it", | ||
| expected: "env.localtest.it", | ||
| }, | ||
| { | ||
| name: "overriding order", | ||
| arg: "arg.localtest.it", | ||
| env: "env.localtest.it", | ||
| expected: "arg.localtest.it", | ||
| }, | ||
| } { | ||
| t.Run(tcase.name, func(t *testing.T) { | ||
| if tcase.env != "" { | ||
| t.Setenv("NODE_NAME", tcase.env) | ||
| } | ||
|
|
||
| err := Setup(tcase.arg) | ||
| if err != nil { | ||
| t.Fatalf("Setup failed: %v", err) | ||
| } | ||
| got := GetNodeName() | ||
| if got != tcase.expected { | ||
| t.Errorf("invalid hostname: got %q expected %q", got, tcase.expected) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func mustHostname() string { | ||
| val, err := os.Hostname() | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| return val | ||
| } |
Oops, something went wrong.