detect: add capability to detect HyperShift platform #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffromani
reviewed
Sep 4, 2024
Added the capeability for the deployer to detect whether the targeted OpenShift platform is of HyperShift flavor. In future PR on NROP, we'll consume this change to allow the operator performs specific decision given the current platform. we're keeping the old \`PlatformFromLister\` for the sake of backward compatability. Signed-off-by: Talor Itzhak <[email protected]>
Tal-or
force-pushed
the
detect_hypershift
branch
from
1e83dc0 to
b9479a3
Compare
|
/hold |
Wanted to check something the diff seemed suspicious. PR is reviewable now. |
ffromani
changed the title
ffromani
approved these changes
Sep 4, 2024
|
I'd be open to a backport to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the capeability for the deployer to detect
whether the targeted OpenShift platform is of HyperShift flavor.
In future PR on NROP, we'll consume this change to allow the operator performs specific decision given the current platform.