[release-0.20][manual add utilities and options to detect control plane #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because an amazing series of coincidence, and lack of real need, the tool itself lacked a way to set its own verbosity. Fixed with this patch, adding the ubiquitous `-v` option. Fixing excessive logging along the way, which was gone unnoticed because the default level was zero. Signed-off-by: Francesco Romani <[email protected]> (cherry picked from commit 0b65fcb)
bubble up into executable (from the root command) the deployer.Environment management, to make room to discover the control plane info. Signed-off-by: Francesco Romani <[email protected]> (cherry picked from commit da17968)
add utilities to getch all the controlplane nodes, similarly to worker node which we support since forever. Signed-off-by: Francesco Romani <[email protected]> (cherry picked from commit c5094bb)
expose control plane detection Signed-off-by: Francesco Romani <[email protected]> (cherry picked from commit 14a53f5)
to avoid to break the render flow, create the client lazily, not eagerly. Signed-off-by: Francesco Romani <[email protected]> (cherry picked from commit 7b8e051)
ffromani
merged commit 3657d32
into
k8stopologyawareschedwg:release-0.20
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add utilities to getch all the controlplane nodes, similarly to worker node which we support since forever.
We can use this code to autodetermine the replica size.