pkg: consolidate options in a package #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We intentionally added per-package Options with the intent to decouple them and make fully independent, hoping to make the packages as easy as possible to consume. Unfortunately things quickly spiralled out of control, and nowadays we have a relatively long chain of rote conversions to do to pass parameters from the higher level packages down to the actual consumers. This is starting to really hurt maintainability, so we move back the pendulum centralizing the Options and reducing them (de-normalizing?). Both approaches are debatable. Centralizing options has its own drawbacks, but at the current state is the lesser evil. This is the beginning of this work, and in future release we are likely to review the approach again. Signed-off-by: Francesco Romani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We intentionally added per-package Options with the intent to decouple them and make fully independent, hoping to make the packages as easy as possible to consume.
Unfortunately things quickly spiralled out of control, and nowadays we have a relatively long chain of rote conversions to do to pass parameters from the higher level packages down to the actual consumers.
This is starting to really hurt maintainability, so we move back the pendulum centralizing the Options and reducing them (de-normalizing?).
Both approaches are debatable. Centralizing options has its own drawbacks, but at the current state is the lesser evil. This is the beginning of this work, and in future release we are likely to review the approach again.
Fixes: #182