Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: remove useless API fields #268

Merged
merged 1 commit into from
Jan 17, 2024
Merged

tree: remove useless API fields #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/commands/deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ func NewDeploySchedulerPluginCommand(env *deployer.Environment, commonOpts *depl
Platform: commonOpts.ClusterPlatform,
WaitCompletion: commonOpts.WaitCompletion,
Replicas: int32(commonOpts.Replicas),
RTEConfigData: commonOpts.RTEConfigData,
PullIfNotPresent: commonOpts.PullIfNotPresent,
ProfileName: commonOpts.SchedProfileName,
CacheResyncPeriod: commonOpts.SchedResyncPeriod,
Expand Down
2 changes: 0 additions & 2 deletions pkg/commands/remove.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ func NewRemoveCommand(env *deployer.Environment, commonOpts *deploy.Options) *co
Platform: commonOpts.ClusterPlatform,
WaitCompletion: commonOpts.WaitCompletion,
Replicas: int32(commonOpts.Replicas),
RTEConfigData: commonOpts.RTEConfigData,
PullIfNotPresent: commonOpts.PullIfNotPresent,
ProfileName: commonOpts.SchedProfileName,
CacheResyncPeriod: commonOpts.SchedResyncPeriod,
Expand Down Expand Up @@ -157,7 +156,6 @@ func NewRemoveSchedulerPluginCommand(env *deployer.Environment, commonOpts *depl
Platform: commonOpts.ClusterPlatform,
WaitCompletion: commonOpts.WaitCompletion,
Replicas: int32(commonOpts.Replicas),
RTEConfigData: commonOpts.RTEConfigData,
PullIfNotPresent: commonOpts.PullIfNotPresent,
ProfileName: commonOpts.SchedProfileName,
CacheResyncPeriod: commonOpts.SchedResyncPeriod,
Expand Down
1 change: 0 additions & 1 deletion pkg/deploy/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ func OnCluster(env *deployer.Environment, commonOpts *Options) error {
Platform: commonOpts.ClusterPlatform,
WaitCompletion: commonOpts.WaitCompletion,
Replicas: int32(commonOpts.Replicas),
RTEConfigData: commonOpts.RTEConfigData,
PullIfNotPresent: commonOpts.PullIfNotPresent,
ProfileName: commonOpts.SchedProfileName,
CacheResyncPeriod: commonOpts.SchedResyncPeriod,
Expand Down
1 change: 0 additions & 1 deletion pkg/deployer/sched/sched.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ type Options struct {
WaitCompletion bool
Replicas int32
ProfileName string
RTEConfigData string
PullIfNotPresent bool
CacheResyncPeriod time.Duration
CtrlPlaneAffinity bool
Expand Down
4 changes: 0 additions & 4 deletions pkg/manifests/nfd/nfd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,6 @@ func (mf Manifests) Clone() Manifests {

type RenderOptions struct {
DaemonSet objectupdate.DaemonSetOptions

// Deployment option
Replicas int32

// General options
Namespace string
}
Expand Down