flagcodec: enable flag normalization #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs to be backportable |
ffromani
force-pushed
the
flagcodec-pflag-compat
branch
from
d7b7a0f to
d994faa
Compare
ffromani
force-pushed
the
flagcodec-pflag-compat
branch
2 times, most recently
from
0412dd9 to
1e42440
Compare
Following the conventions outlined in RATIONALE.md, the pflag packages allows using both `--v` and `-v` (double or single dashes for single-letter flags), but the flagcodec package wasn't behaving the same, treating the two flags as different. We add options to conform to our own rationale and to be more compatible with pflag. Signed-off-by: Francesco Romani <[email protected]>
Always enable normalization in the deployer codebase. The golang flag package also allows single or double dash for single-letter flags: https://pkg.go.dev/flag#hdr-Command_line_flag_syntax Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
flagcodec-pflag-compat
branch
from
1e42440 to
99b7fc6
Compare
ffromani
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the conventions outlined in RATIONALE.md,
the pflag packages allows using both
--vand-v(double or single dashes for single-letter flags), but
the flagcodec package wasn't behaving the same, treating
the two flags as different.
We add options to conform to our own rationale and to
be more compatible with pflag.