cleanups: fix linter issues 20231026 #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure to use the up-to-date function, honoring context and make it cancellable. Not intended change in behavior. Signed-off-by: Francesco Romani <[email protected]>
cosmetic change only Signed-off-by: Francesco Romani <[email protected]>
make sure to bubble up error, and don't leak response body. This code should run only once per `deployer` execution, but still let's not leak resources if we can help it. Signed-off-by: Francesco Romani <[email protected]>
make sure we bail out on error if fail to set the field. Signed-off-by: Francesco Romani <[email protected]>
make sure to bubble up errors if we fail to teardown the proxy. We should not leak processes. Signed-off-by: Francesco Romani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the linter run revealed a good bit of potential issues.
Please check each commit for context and rationale