wait: consolidate command line wait path #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add global values, and global settings, to enable overriding of default poll interval and default poll timeout. This is admittedly a very unpolished solution but we start simple and fixing the cmdline UX until we get better clarity about how a more polished solution could look like. Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
configurable-wait-timeout
branch
from
0c33dec to
2981ebf
Compare
waitable objects are needed by the commandline flow, not by packages proper. Until a better API emerges, isolate the related code in a separate package. Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
configurable-wait-timeout
branch
from
2981ebf to
a4c6d84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commandline UX improvement for waitable objects: enable to set base (global) values.
Since this code is used only in command flow (e.g. not really needed by library code), start isolating it in their own source code files, until a more comprehensive reorganization happens.
Fixes: #201