Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sched: manifests: run on the control plane #199

Merged

Conversation

ffromani
Copy link
Collaborator

the scheduler is a control plane component, thus it should run by default on the control plane.

Fixes: #177

@ffromani ffromani force-pushed the sched-run-control-plane branch 2 times, most recently from 2b58f39 to 72e7273 Compare June 14, 2023 11:54
@ffromani
Copy link
Collaborator Author

HOLD! failures are legit and needs to be investigated. And e2e tests can use some improvements

@ffromani ffromani force-pushed the sched-run-control-plane branch 4 times, most recently from 92e6a41 to ecbb52e Compare June 20, 2023 06:39
ffromani added 4 commits June 20, 2023 09:09
extra debug logs to troubleshoot failures.
Oftentimes, we just run out of resources because very
limited capacity on free CI tiers.
Describing nodes gives us at least insight on available resources.

Signed-off-by: Francesco Romani <[email protected]>
the scheduler is a control plane component, thus
it should run by default on the control plane.

Signed-off-by: Francesco Romani <[email protected]>
In order to make troubleshooting easier, when deployment fails
we now dump the pod object (including status) and the related
events. We start with scheduler for now.

Signed-off-by: Francesco Romani <[email protected]>
The free tier CI machines are too weak, so the
control plane kind node has not enough CPU to also
run the secondary scheduler.

For now, we force off the feature to run on control plane
in order to unblock CI.

Signed-off-by: Francesco Romani <[email protected]>
@ffromani ffromani force-pushed the sched-run-control-plane branch from ecbb52e to 596cbf4 Compare June 20, 2023 08:00
@ffromani ffromani requested a review from Tal-or June 20, 2023 08:00
@ffromani
Copy link
Collaborator Author

failures fixed... by disabling the option by default on CI :\

@ffromani ffromani merged commit f806d05 into k8stopologyawareschedwg:main Jun 20, 2023
@ffromani ffromani deleted the sched-run-control-plane branch June 20, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manifests: scheduler should run in the control plane (default, but overridable)
1 participant