Cleanup 20230406 #192
Merged
Cleanup 20230406 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useless, add by mistake back in time Signed-off-by: Francesco Romani <[email protected]>
The manifests we ship are private and implementation details. They are meant to be accessed through go code, never directly. So un-expose them. Signed-off-by: Francesco Romani <[email protected]>
add basic testcases for FindContainerByName Signed-off-by: Francesco Romani <[email protected]>
add target to run unit tests and generate coverage Signed-off-by: Francesco Romani <[email protected]>
add basic coverage Signed-off-by: Francesco Romani <[email protected]>
add basic coverage Signed-off-by: Francesco Romani <[email protected]>
This is the only sit on which we use consts, so move them here removing dead code in the process. Signed-off-by: Francesco Romani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grab-bag of minor fixes and cleanups