Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifests: ocp: rte: remove hardcoded TM setting #116

Conversation

ffromani
Copy link
Collaborator

@ffromani ffromani commented Sep 8, 2022

Long, long ago, we added a OCP-specific setting to fix the TM policy, because OCP doesn't allow to read the kubelet config.

Since then, OCP made progress and provided better option to tell RTE which is the TM policy configured (e.g. operator).

We can and should now get rid of this hardcoded default.

Signed-off-by: Francesco Romani [email protected]

@ffromani ffromani requested a review from Tal-or September 8, 2022 06:57
Long, long ago, we added a OCP-specific setting to fix the TM policy,
because OCP doesn't allow to read the kubelet config.

Since then, OCP made progress and provided better option to tell RTE
which is the TM policy configured (e.g. operator).

We can and should now get rid of this hardcoded default.

Signed-off-by: Francesco Romani <[email protected]>
@ffromani ffromani force-pushed the remove-ocp-tm-hardcoded-policy branch from a5f56c5 to 2ff6db9 Compare September 8, 2022 07:19
@ffromani ffromani requested a review from swatisehgal September 8, 2022 08:46
Copy link
Collaborator

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@swatisehgal swatisehgal merged commit 6efa73b into k8stopologyawareschedwg:main Sep 8, 2022
@ffromani ffromani deleted the remove-ocp-tm-hardcoded-policy branch September 8, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants