-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
selinuxpolicy: updates to enable support for OCP 4.11+/K8s 1.24+ #107
selinuxpolicy: updates to enable support for OCP 4.11+/K8s 1.24+ #107
Conversation
/cc @fromanirh |
1adbad8
to
9b7a2b3
Compare
very nice start! |
55fb124
to
ce1d3eb
Compare
62fcc9e
to
be11cad
Compare
thanks for the updates. Looks very good. It seems to me that we only miss to update the
(note your naming is actually better than the one I used in the quick example above, please use yours :) ) similar changes would be needed all across |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor improvements inside
9b193f6
to
1367489
Compare
Need to tidy up a couple of things, on it now. |
In container-selinux versions v2.186.0, v2.187.0 and v2.188.0, due to the updates here: containers/container-selinux@cf704e4 selinuxpolicy updates are required (updating `container_runtime_t` to `kubelet_t`). This is consumed in OCP 4.11 and K8s 1.24 and we need to make sure that the selinuxpolicy is appropriately updated. In addition to that, we need to continue supporting the older selinuxpolicy supplied in older versions (e.g. 4.10) and that is the reason this patch is proposing an additional selinuxpolicy and not completely replacing the original one. Signed-off-by: Swati Sehgal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there. You properly detect the version in the right places, but we need to pass it through another layer
1367489
to
563d050
Compare
Rather than calling detect.Version in the manifest package, we obtain the version from the top level CommonOptions and pass it all the way to the manifest package where the platform version is taken into consideration when loading the selinux policy. Signed-off-by: Swati Sehgal <[email protected]>
563d050
to
fb42881
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
we detect the version in more places than is strictly needed. But let's keep it this way, should make the overall UX less surprising.
In container-selinux versions v2.186.0, v2.187.0 and v2.188.0, due to the updates here:
containers/container-selinux@cf704e4
selinuxpolicy updates are required (updating
container_runtime_t
tokubelet_t
).This is consumed in OCP 4.11 and K8s 1.24 and we need to make sure that the selinuxpolicy is
appropriately updated.
In addition to that, we need to continue supporting the older selinuxpolicy supplied in older
versions (e.g. 4.10) and that is the reason this patch is proposing an additional selinuxpolicy
and not completely replacing the original one.
Signed-off-by: Swati Sehgal [email protected]