Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: detect cluster version alongside platform #104

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

ffromani
Copy link
Collaborator

@ffromani ffromani commented Jul 12, 2022

We will soon need to support version-specific configuration (e.g. in MachineConfig).
To enable this, we add the concept of platform version (retroactively renaming the current platform as "kind") all across the stack.

This is a API-breaking enablement PR only: consumers of this new data will be added in future PRs.
Signed-off-by: Francesco Romani [email protected]

@ffromani ffromani force-pushed the plat-detect-version branch 6 times, most recently from 4bc1e9c to a95fa70 Compare July 12, 2022 10:22
@ffromani ffromani changed the title WIP: pkg: detect cluster version alongside platform pkg: detect cluster version alongside platform Jul 12, 2022
@ffromani ffromani added the api-breaking This change will break API backwards compatibility label Jul 12, 2022
@ffromani ffromani requested review from Tal-or and swatisehgal July 12, 2022 10:24
Copy link
Collaborator

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/deployer/platform/version.go Outdated Show resolved Hide resolved
We will soon need to support version-specific configuration
(e.g. in MachineConfig).
To enable this, we add the concept of platform version (retroactively
renaming the current platform as "kind") all across the stack.

This is a API-breaking enablement PR only: consumers of this new
data will be added in future PRs.

X-API-Breaking: yes
Signed-off-by: Francesco Romani <[email protected]>
@ffromani ffromani force-pushed the plat-detect-version branch from a95fa70 to c082682 Compare July 12, 2022 16:13
@ffromani ffromani merged commit 4edd92a into k8stopologyawareschedwg:main Jul 12, 2022
@ffromani ffromani deleted the plat-detect-version branch July 12, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-breaking This change will break API backwards compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants