pkg: commands: refactor commands to make them reusable #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffromani
force-pushed
the
reusable-commands
branch
from
6d8c76c to
71a084a
Compare
In order to facilitate integration of the `commands` package - which was an original goal, extract helpers to register flags and parse options. This is useful because subcommands all require the CommonOptions, which are handled by the `root` command using the code being factored out. This change makes it easier to integrate the subcommands without requiring anymore the root command. Signed-off-by: Francesco Romani <[email protected]>
Subcommand require sub-options structs, which were not exported previously, forcing client code to pass `nil`, which is fragile and works on a very narrow subset of cases. Exporting the sub-options enables clients to register subcommands safely. Signed-off-by: Francesco Romani <[email protected]>
expose and simplify RenderManifests, to enable client of the `commands` package to register sub-commands without requiring to (possibly akwardly) register the full render subcommand. This allow to unnest the command tree. Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
reusable-commands
branch
from
71a084a to
9a7cf0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intent of the
commandspkg was to be reusable, to enable clients to inject deployer commands in their own programs. This turns out harder than expected in practice, because of somehow excessive coupling in thecommandspkg.This PR relaxes these contraints and make sure that these commands, at least the
rendersubtree, is actually reusable in external projects.