e2e: split deployment + validation test #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have tests which do the overall deployment AND perform the minimal validation on top of it. Due to lack of CI resources, we always skip the validation, but this also incorrectly marks the deployment as skipped. Let's split the tests to get a better signal; while the validation is expected to keep skipping, we can get a better understanding from the deployment test. Signed-off-by: Francesco Romani <[email protected]>
|
/approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have tests which do the overall deployment AND
perform the minimal validation on top of it.
Due to lack of CI resources, we always skip the validation, but
this also incorrectly marks the deployment as skipped.
Let's split the tests to get a better signal; while the
validation is expected to keep skipping, we can get a better
understanding from the deployment test.
Signed-off-by: Francesco Romani [email protected]