Write metric filters provided as an env variable to the MCAC config file #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emerkle826
requested changes
Oct 18, 2021
| @@ -2,7 +2,7 @@ ARG CASSANDRA_VERSION=4.0.1 | |||
|
|
|||
| FROM --platform=$BUILDPLATFORM maven:3.6.3-jdk-8-slim as builder | |||
|
|
|||
| ARG METRICS_COLLECTOR_VERSION=0.2.0 | |||
| ARG METRICS_COLLECTOR_VERSION=0.3.0 | |||
There was a problem hiding this comment.
You need to make the same change in the C* 3.11 Dockerfile here:
https://github.com/k8ssandra/management-api-for-apache-cassandra/blob/master/Dockerfile-oss#L5
There was a problem hiding this comment.
gotcha, thanks!
adejanovski
force-pushed
the
apply-metrics-filters
branch
from
0054442 to
2a287c0
Compare
emerkle826
approved these changes
Oct 19, 2021
|
The 0.3.0 release of MCAC is out now. I'll merge this PR as I successfully tested the upcoming filters on K8ssandra with 500 tables without any scraping interruption nor dropped metrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires this MCAC PR to be merged and v0.3.0 to be released.
The env variable used to provide the metric filters is named
METRIC_FILTERSand should be provided in the following format:"deny:org.apache.cassandra.metrics.table allow:org.apache.cassandra.metrics.table.test1 allow:org.apache.cassandra.metrics.table.test2"This PR is part of the work described here: https://k8ssandra.atlassian.net/browse/K8SSAND-874