Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ShellUtils arbitrary command execution #441

Closed
emerkle826 opened this issue Dec 20, 2023 · 0 comments · Fixed by #442
Closed

Replace ShellUtils arbitrary command execution #441

emerkle826 opened this issue Dec 20, 2023 · 0 comments · Fixed by #442
Assignees
@emerkle826
Labels
done Issues in the state 'done'

Comments

@emerkle826
Copy link
Contributor

The ShellUtils class allows for arbitrary command execution here, here, and here. We should refactor this class so that the commands executed are sanitized, similar to what was done in DSE for DSP-22272
@emerkle826 emerkle826 mentioned this issue Dec 20, 2023
Merged
@emerkle826 emerkle826 moved this to Ready For Review in K8ssandra Mar 20, 2024
@adejanovski adejanovski added the ready-for-review Issues in the state 'ready-for-review' label Mar 20, 2024
@emerkle826 emerkle826 self-assigned this Mar 20, 2024
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in K8ssandra Mar 21, 2024
@adejanovski adejanovski added done Issues in the state 'done' and removed ready-for-review Issues in the state 'ready-for-review' labels Mar 21, 2024
emerkle826 added a commit that referenced this issue Mar 21, 2024
@emerkle826
Release v0.1.74
8dec53e 
* [FEATURE] [#453](#453) Use a longer driver timeout for drain
* [FEATURE] [#455](#455) Add DSE 6.8.43 to the build matrix
* [FEATURE] [#458](#458) Update MCAC to v0.3.5
* [ENHANCEMENT] [#441](#441) Replace ShellUtils arbitrary command execution
alaye-ms added a commit to microsoft/management-api-for-apache-cassandra that referenced this issue Apr 1, 2024
@alaye-ms
Merge tag 'v0.1.74' into users/alaye/upstreamPlus5.0Fix
c398809 
Release v0.1.74

* [FEATURE] [k8ssandra#453](k8ssandra#453) Use a longer driver timeout for drain
* [FEATURE] [k8ssandra#455](k8ssandra#455) Add DSE 6.8.43 to the build matrix
* [FEATURE] [k8ssandra#458](k8ssandra#458) Update MCAC to v0.3.5
* [ENHANCEMENT] [k8ssandra#441](k8ssandra#441) Replace ShellUtils arbitrary command execution
alaye-ms added a commit to microsoft/management-api-for-apache-cassandra that referenced this issue Apr 2, 2024
@alaye-ms
Merge tag 'v0.1.74' into users/alaye/upstreamPlus5.0Fix
9d5610b 
Release v0.1.74

* [FEATURE] [k8ssandra#453](k8ssandra#453) Use a longer driver timeout for drain
* [FEATURE] [k8ssandra#455](k8ssandra#455) Add DSE 6.8.43 to the build matrix
* [FEATURE] [k8ssandra#458](k8ssandra#458) Update MCAC to v0.3.5
* [ENHANCEMENT] [k8ssandra#441](k8ssandra#441) Replace ShellUtils arbitrary command execution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerkle826 emerkle826

Labels
done Issues in the state 'done'
Projects
No open projects
K8ssandra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace ShellUtils arbitrary command execution k8ssandra/management-api-for-apache-cassandra
2 participants
@emerkle826 @adejanovski