Skip pods marked for deletion #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where the amount of ips is limited, pods affected by a node shutdown remain in Terminating state and do not release their allocations. Deployments are not able to create pods in healthy nodes due to the lack of ips. These changes force the ip reconciler to skip pods marked as deletion by a Taint Manager. The toleration node.kubernetes.io/unreachable is expected to trigger this. However, it is safe if other tolerations with NoExecute also trigger the cleaning up. Signed-off-by: Marcelo Guerrero <[email protected]>
Pull Request Test Coverage Report for Build 9855678107Details
💛 - Coveralls |
mlguerrero12
changed the title
dougbtv
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the amount of ips is limited, pods affected by a node shutdown remain in Terminating state and do not release their allocations. Deployments are not able to create pods in healthy nodes due to the lack of ips. These changes force the ip reconciler to skip pods marked as deletion by a Taint Manager. The toleration node.kubernetes.io/unreachable is expected to trigger this. However, it is safe if other tolerations with NoExecute also trigger the cleaning up.