Return previous IP allocation for add cmd #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mlguerrero12
commented
May 15, 2024
•
mlguerrero12
commented
- This allows the cni to return a previous allocation for a pod with the same podRef and interface name. This is needed on networks with limited IPs.
- A new property called Interface was added on the API in order to uniquely identify allocations for pods with multiple interfaces.
- Testing was improved and new cases (multiple interfaces and reclaim previous allocations) are added.
- New field does not break backwards compatibility. Users that wish to solve the issue of limited ip reservations in statefulsets will have to recreate the pods to have this new field populated.
mlguerrero12
force-pushed
the
addifnameapi
branch
10 times, most recently
from
09439c6
to
e57f5d9
Compare
mlguerrero12
changed the title
Signed-off-by: Marcelo Guerrero <[email protected]>
Signed-off-by: Marcelo Guerrero <[email protected]>
mlguerrero12
force-pushed
the
addifnameapi
branch
from
e57f5d9
to
01105cf
Compare
Pull Request Test Coverage Report for Build 9402269686Details
💛 - Coveralls |
|
@mlguerrero12 I can't find the code for updating the existing IP allocation records. Did you take care of that in this PR? |
pliurh
reviewed
May 30, 2024
pkg/api/whereabouts.cni.cncf.io/v1alpha1/overlappingrangeipreservation_types.go
Outdated
Show resolved
Hide resolved
pliurh
reviewed
May 31, 2024
pliurh
reviewed
May 31, 2024
This is needed in order to uniquely identify allocations for pods with multiple interfaces. These allocations have the same podRef. Signed-off-by: Marcelo Guerrero <[email protected]>
Support the new Interface property on IP and cluster wide allocations. Signed-off-by: Marcelo Guerrero <[email protected]>
This allows to validate the lifecycle of allocations for single and multiple interfaces pods. Signed-off-by: Marcelo Guerrero <[email protected]>
This allows the cni to return a previous allocation for a pod with the same podRef and interface name. This is needed on networks with limited IPs. Signed-off-by: Marcelo Guerrero <[email protected]>
No, I decided not to add this functionality. It will be more overhead for little gain in my opinion. Everything will continue working, so it does not break backwards compatibility. Users that wish to solve the issue of limited ip reservations in statefulsets will have to recreate the pods to have this new field populated. |
mlguerrero12
force-pushed
the
addifnameapi
branch
from
01105cf
to
b3a0025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.