Improve AssignmentError message #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Karis <[email protected]>
andreaskaris
force-pushed
the
assignment-error
branch
from
863eaaa
to
c7c49b8
Compare
andreaskaris
commented
Jul 19, 2023
| } | ||
|
|
||
| func (a AssignmentError) Error() string { | ||
| return fmt.Sprintf("Could not allocate IP in range: ip: %v / - %v / range: %#v", a.firstIP, a.lastIP, a.ipnet) | ||
| return fmt.Sprintf("Could not allocate IP in range: ip: %v / - %v / range: %s / excludeRanges: %v", | ||
| a.firstIP, a.lastIP, a.ipnet.String(), a.excludeRanges) |
There was a problem hiding this comment.
Note: I must do a.ipnet.String() because otherwise it looks like this:
range: {2000:: ffffffffffffffff0000000000000000}
And with it it looks like this:
range: 2000::/64
dougbtv
approved these changes
Jul 21, 2023
| } | ||
|
|
||
| func (a AssignmentError) Error() string { | ||
| return fmt.Sprintf("Could not allocate IP in range: ip: %v / - %v / range: %#v", a.firstIP, a.lastIP, a.ipnet) | ||
| return fmt.Sprintf("Could not allocate IP in range: ip: %v / - %v / range: %s / excludeRanges: %v", | ||
| a.firstIP, a.lastIP, a.ipnet.String(), a.excludeRanges) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer (optional):
Before:
After: