Add overlapping ranges check to network_name feature #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Karis <[email protected]>
andreaskaris
changed the title
andreaskaris
force-pushed
the
network-name-overlappingipreservations
branch
3 times, most recently
from
a3f97b7
to
b78ddbb
Compare
The network_name feature lacked integration for parameter enable_overlapping_ranges which had to be set to off. Add support for this parameter to networks with a non-default network_name by creating overlappingipreservations which are prefixed with the network_name. Signed-off-by: Andreas Karis <[email protected]>
andreaskaris
force-pushed
the
network-name-overlappingipreservations
branch
from
b78ddbb
to
f4a278e
Compare
Signed-off-by: Andreas Karis <[email protected]>
dougbtv
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) Add overlapping ranges check to network_name feature
The network_name feature lacked integration for parameter
enable_overlapping_ranges which had to be set to off. Add support for
this parameter to networks with a non-default network_name by creating
overlappingipreservations which are prefixed with the network_name.
b) Add documentation for parameter network_name in README.md
c) Add E2E tests for OverlappingRangeIPReservation
Special notes for your reviewer (optional):
This should complete the requirements for OpenShift RFE https://issues.redhat.com/browse/RFE-3321?