Support test-e2e-k8s rule #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adrianchiris can you have a look? thanks |
moshe010
approved these changes
Mar 30, 2021
martinkennelly
approved these changes
Mar 30, 2021
test/e2e/e2e_tests_suite_test.go
Outdated
| timeout = time.Second * 30 | ||
| duration = time.Second * 300 | ||
| interval = time.Second * 1 | ||
| ) | ||
|
|
||
| var testNamespace string = os.Getenv("NAMESPACE") |
There was a problem hiding this comment.
Should we panic in the test if NAMESPACE is somehow not defined (i.e os.Gentenv() returns an empty string) ?
|
@AbdYsn a small comment, otherwise i think we are good to merge this one ! |
This patch adds the support for the `test-e2e-k8` make rule by making the operator namespace in the e2e tests configurable then setting the namespace value in the Makefile.
abdallahyas
force-pushed
the
e2e-k8s-support
branch
from
6c3e721 to
6ee759f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the support for the
test-e2e-k8make rule bymaking the operator namespace in the e2e tests configurable then
setting the namespace value in the Makefile.