Sync node policies when node labels change only #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following from [1], fix the condition for calling the SriovNetworkNodePolicy reconciler on node updates, which is "only when a label changes". [1] k8snetworkplumbingwg@baa41c9#diff-d443e0d8dad7ac4f492a0601edbf9bfeec42ce8a496c020c0949e22b26442336R138-R183 Signed-off-by: Andrea Panattoni <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
Pull Request Test Coverage Report for Build 13767785207Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following from [1], fix the condition for calling the
SriovNetworkNodePolicy reconciler on node updates, which
is "only when a label changes".
[1] baa41c9#diff-d443e0d8dad7ac4f492a0601edbf9bfeec42ce8a496c020c0949e22b26442336R138-R183