Flaky Coveralls failures #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
zeeke
force-pushed
the
us/flaky-coveralls
branch
from
77df5f8 to
1bd65a7
Compare
Pull Request Test Coverage Report for Build 12274846267Details
💛 - Coveralls |
ykulazhenkov
approved these changes
Dec 9, 2024
SchSeba
reviewed
Dec 11, 2024
| ).ToNot(HaveOccurred()) | ||
| }) | ||
|
|
||
| It("field is correctly written to the SriovNetworkNodePolicy", func() { |
Signed-off-by: Andrea Panattoni <[email protected]>
Signed-off-by: Andrea Panattoni <[email protected]>
zeeke
force-pushed
the
us/flaky-coveralls
branch
from
1bd65a7 to
fdffa3d
Compare
SchSeba
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wants to solve the failures of the Coveralls actions: sometimes, the function
findNodePoolConfig(...)results in low coverage. This is probably because of some test flakiness.Also, the CI invokes
make test-controllersandCLUSTER_TYPE=openshift make test-controllers. Both steps overridescover-controllers.outand the proposed changes avoid this problem.see following sample builds: