-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add feature gates to our readme #756
Merged
SchSeba
merged 1 commit into
k8snetworkplumbingwg:master
from
tobiasgiese:add-featuregates-readme
Aug 12, 2024
Merged
docs: add feature gates to our readme #756
SchSeba
merged 1 commit into
k8snetworkplumbingwg:master
from
tobiasgiese:add-featuregates-readme
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
tobiasgiese
force-pushed
the
add-featuregates-readme
branch
2 times, most recently
from
August 12, 2024 09:48
b7931d0
to
f3b84a5
Compare
Pull Request Test Coverage Report for Build 10350466058Details
💛 - Coveralls |
tobiasgiese
force-pushed
the
add-featuregates-readme
branch
from
August 12, 2024 09:56
f3b84a5
to
7a444ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit, overall LGTM
Signed-off-by: Tobias Giese <[email protected]>
tobiasgiese
force-pushed
the
add-featuregates-readme
branch
from
August 12, 2024 10:49
7a444ed
to
edf9cab
Compare
We should wait until #733 is merged IMO |
5 tasks
SchSeba
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature gates section to our README.
Depends on #733