Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add background to workflow png #745

Merged

Conversation

tobiasgiese
Copy link
Contributor

@tobiasgiese tobiasgiese commented Jul 23, 2024

With the GH dark theme ~40% of the image is not readable. Setting the images background to white fixes this issue.

Before:

image

After:

image

Note: also cropped the image a little bit.

With the GH dark theme 40% of the image is not readable.
Setting the images background to white fixes this issue.

Signed-off-by: Tobias Giese <[email protected]>
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10057018685

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 43.386%

Totals Coverage Status
Change from base Build 10054586683: 0.04%
Covered Lines: 6346
Relevant Lines: 14627

💛 - Coveralls

Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianchiris adrianchiris merged commit 4dd8dce into k8snetworkplumbingwg:master Jul 23, 2024
14 checks passed
@tobiasgiese tobiasgiese deleted the add-bg-workflow-png branch July 23, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants