Fix reconcile vf functional test #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
Pull Request Test Coverage Report for Build 10351277379Details
💛 - Coveralls |
SchSeba
force-pushed
the
fix_mtu_test_1
branch
3 times, most recently
from
d98b652 to
377410f
Compare
zeeke
reviewed
Aug 1, 2024
| networkStatusJSON, exist := firstPod.Annotations["k8s.v1.cni.cncf.io/network-status"] | ||
| Expect(exist).To(BeTrue()) | ||
| Expect(networkStatusJSON).To(ContainSubstring("\"mtu\": 9000")) | ||
| Eventually(func() error { |
There was a problem hiding this comment.
can you use waitForNetAttachDef() here?
| stdout, stderr, err = pod.ExecCommand(clients, firstPod, "ip", "link", "show", "net1") | ||
| if stdout == "" { | ||
| return fmt.Errorf("empty response from pod exec") | ||
| // update the interface |
There was a problem hiding this comment.
please, extract a function like
Suggested change
| // update the interface | |
| intf = getInterfaceFromNodeStateByPciAddress(node, intf.PciAddr) | |
| func getInterfaceFromNodeStateByPciAddress(node, pciAddress string) { | |
| nodeState := &sriovv1.SriovNetworkNodeState{} | |
| err = clients.Get(context.Background(), runtimeclient.ObjectKey{Name: node, Namespace: operatorNamespace}, nodeState) | |
| Expect(err).ToNot(HaveOccurred()) | |
| found := false | |
| for _, state := range nodeState.Status.Interfaces { | |
| if state.PciAddress == intf.PciAddress { | |
| intf = state.DeepCopy() | |
| found = true | |
| break | |
| } | |
| } | |
| Expect(found).To(BeTrue()) | |
| } |
WDYT?
SchSeba
force-pushed
the
fix_mtu_test_1
branch
from
377410f to
b789933
Compare
|
Hi @zeeke when you have time please take another look :) |
we should not lower the MTU on a primary SDN nic. with this change we select a PF that is not the default route of the node or not the nic connected to the ovs bridge for openshift Signed-off-by: Sebastian Sch <[email protected]>
SchSeba
force-pushed
the
fix_mtu_test_1
branch
from
b789933 to
09d5f75
Compare
adrianchiris
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should not lower the MTU on a primary SDN nic.
with this change we select a PF that is not the default route of the node or not the nic connected to the ovs bridge for openshift