Skip firmware reset on devices the operator doesn't control #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 9938668005Details
💛 - Coveralls |
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
| _, exist, err := p.helpers.LoadPfsStatus(iface.PciAddress) | ||
| if err != nil { | ||
| log.Log.Error(err, "failed to load PF status from disk", "address", iface.PciAddress) | ||
| continue |
There was a problem hiding this comment.
should we fail here ?
There was a problem hiding this comment.
There was a problem hiding this comment.
perhaps we shoud consider failing in both places, LMK what you think i can submit a followup PR.
LoadPfStatus will fail if file exists but it failed reading from it or its corrupt and we werent able to unmarshall
There was a problem hiding this comment.
sounds good I agree that should failed in both functions :)
when you have time please open the PR I can review it
adrianchiris
approved these changes
Jul 14, 2024
zeeke
reviewed
Jul 15, 2024
zeeke
approved these changes
Jul 15, 2024
Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the user allocate vf or configure the mellanox card firmware and we don't have any policy in the operator we should not reset that configuration