Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 1.22.4 #729

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Bump to 1.22.4 #729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/k8snetworkplumbingwg/sriov-network-operator

go 1.22
go 1.22.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bn222 why do we need to require .4 explicitly ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gopls doesn't work with non-explicit z-stream. Also, our images downstream are 1.22.4. Making it explicit brings our env and upstream in alignment.

Side note: A difference between 1.22.1 and 1.22.4 causes code gen to behave differently. Making it explicit makes sure everyone is generating the same code.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this approach. It will force us to. make more updates (1.22.5 is already releases). Could you please provide any real example how this will help?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • gopls lsp servers doesn't work when you don't specify 1.22.4. There is an issue between 1.22.0 and 122.4.
  • I'm not recommending always bumping versions to z-stream. If 1.22.5, we don't necessarily want it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, As far as I know. version specified in the go.mod file is the minum required version for this project to build.

https://go.dev/doc/modules/gomod-ref

So, there will be no need to bump this in the future in my opinion.

@bn222 do you have any reference (github issue, stackoverflow) to the problem with gopls?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NixOS/nixpkgs#293180

Copy link
Collaborator Author

@bn222 bn222 Jul 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the closest I can find. On my system, after I've added .4, it started working.
Note also that operator-sdk generates a bit different code depending on 1.22 vs 1.22.4, so if someone is on 1.22.4, and they run make generate, they will generate different code than someone who is running on 1.22. IMO, it's better to be explicit on which version everyone should be on.


require (
github.com/Masterminds/sprig/v3 v3.2.2
Expand Down
Loading