Set link state up for target ports of SriovNetworkNodePolicy for kubernetes cluster #72
Conversation
| // Set PF link up for kubernetes cluster | ||
| if ClusterType == ClusterTypeKubernetes && ifaceStatus.Name != "" { | ||
| pfLink, err := netlink.LinkByName(ifaceStatus.Name) | ||
| if err != nil { |
There was a problem hiding this comment.
you can check if the pfLink is not up with
pfLink.Attrs().OperState == OperUp or something like that.
Also in what case ifaceStatus.Name will be ""?
There was a problem hiding this comment.
If some modules are not loaded like ipoib for IB interfaces
There was a problem hiding this comment.
Added condition for state and removed the condition for name
Mmduh-483
force-pushed
the
k8s-cluster-pf-state
branch
from
304caa3 to
de56cca
Compare
pkg/utils/utils.go
Outdated
| @@ -315,6 +315,19 @@ func configSriovDevice(iface *sriovnetworkv1.Interface, ifaceStatus *sriovnetwor | |||
| } | |||
| } | |||
| } | |||
| // Set PF link up for kubernetes cluster | |||
| if ClusterType == ClusterTypeKubernetes { | |||
There was a problem hiding this comment.
Is there a reason this is special for k8s cluster?
There was a problem hiding this comment.
So we encounter this is k8s vanilla, we can remove this check if you think it make sense openshift.
There was a problem hiding this comment.
Thanks Moshe!
I think it's fine to enable it for both cluster types, as long as there is numvfs configured for that device, link state will be set to up.
/cc @pliurh
There was a problem hiding this comment.
In openshift, the NetworkManager will do the job. Shall we check whether the link-state first before setting it to up?
There was a problem hiding this comment.
There is a check for the state if pfLink.Attrs().OperState != netlink.OperUp
…rnetes cluster Signed-off-by: Mamduh Alassi <[email protected]>
Mmduh-483
force-pushed
the
k8s-cluster-pf-state
branch
from
de56cca to
ab7165e
Compare
fixes #45