[metrics 3/x] end-to-end tests #702

zeeke · 2024-05-22T14:11:13Z

Exposed metrics can be verified by scraping the prometheus
endpoint on the sriov-network-metrics-exporter pod.
Add a test that spawns an SR-IOV consuming pod and verifies
its receiving counter increase when the interface is pinged from
outside.

depends on:

[metrics 2/x] Configure Prometheus Operator #687

github-actions · 2024-05-22T14:11:29Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-05-22T14:12:24Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2024-05-22T14:18:46Z

Pull Request Test Coverage Report for Build 10453520475

Details

0 of 0 changed or added relevant lines in 0 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 44.972%

Files with Coverage Reduction	New Missed Lines	%
controllers/generic_network_controller.go	5	74.53%

Totals
Change from base Build 10354035877:	-0.03%
Covered Lines:	6529
Relevant Lines:	14518

💛 - Coveralls

github-actions · 2024-05-22T14:21:13Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-05-22T14:36:28Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-05-22T15:31:03Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-05-22T17:21:02Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-05-22T17:21:59Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-05-23T01:51:44Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-05-23T12:18:04Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

test/conformance/tests/test_exporter_metrics.go

SchSeba · 2024-06-03T11:14:54Z

test/conformance/tests/test_exporter_metrics.go

+
+	metricsExporterPod := metricsExporterPods.Items[0]
+
+	command := []string{"wget", "-qO-", "http://127.0.0.1:9110/metrics"}


please switch this one to curl as in the ubi images we don't have wget

Trying to pull registry.redhat.io/ubi9/ubi:latest... Getting image source signatures Checking if image destination supports signatures Copying blob bb65efb0bec6 done Copying config 02eedf8dcc done Writing manifest to image destination Storing signatures [root@d7d4fbbaf778 /]# wget bash: wget: command not found [root@d7d4fbbaf778 /]# curl curl: try 'curl --help' for more information

sure! no problem!

SchSeba · 2024-06-03T11:21:36Z

test/conformance/tests/test_exporter_metrics.go

+		finalRxPackets := getCounterForPod(finalMetrics, pod, "sriov_vf_rx_packets")
+
+		Expect(finalRxBytes).Should(BeNumerically(">", initialRxBytes))
+		Expect(finalRxPackets).Should(BeNumerically(">", initialRxPackets+3))


why you add the +3 here?

Because pingPod(...) function sends 3 ICMP packets

sriov-network-operator/test/conformance/tests/test_sriov_operator.go

Lines 2652 to 2669 in a8476f0

func pingPod(ip string, nodeSelector string, sriovNetworkAttachment string) {

ipProtocolVersion := "6"

if len(strings.Split(ip, ".")) == 4 {

ipProtocolVersion = "4"

}

podDefinition := pod.RedefineWithNodeSelector(

pod.RedefineWithCapabilities(

pod.RedefineWithRestartPolicy(

pod.RedefineWithCommand(

pod.DefineWithNetworks([]string{sriovNetworkAttachment}),

[]string{"sh", "-c", fmt.Sprintf("ping -%s -c 3 %s", ipProtocolVersion, ip)}, []string{},

),

corev1.RestartPolicyNever,

),

[]corev1.Capability{"NET_RAW"},

),

nodeSelector,

)

I could refactor that function a bit to make this information more explicit

is it not enough to keep the check > initialRxPackets ?

yes, it is. It would also be clearer as the number "3" is hidden in another function.

fixing

github-actions · 2024-07-05T13:48:19Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-07-05T13:59:26Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

adrianchiris

lgtm

SchSeba · 2024-08-19T11:15:30Z

test/conformance/tests/test_exporter_metrics.go

+		By("Enabling `metricsExporter` feature flag")
+		setFeatureFlag("metricsExporter", true)
+
+		By("Adding ")


nit: can you fix this BY

SchSeba · 2024-08-19T11:20:09Z

test/conformance/tests/test_exporter_metrics.go

+	return true
+}
+
+func addLabelToNamespace(ctx context.Context, namespaceName, key, value string) error {


nit: can you move this to utils.namespace please

Exposed metrics can be verified by scraping the prometheus endpoint on the `sriov-network-metrics-exporter` pod. Add a test that spawns an SR-IOV consuming pod and verifies its receiving counter increase when the interface is pinged from outside. Signed-off-by: Andrea Panattoni <[email protected]>

SchSeba

LGTM nice work!

zeeke force-pushed the metrics-exporter-test branch from 4ae399a to 87f725c Compare May 22, 2024 14:12

zeeke force-pushed the metrics-exporter-test branch from 87f725c to 2e4cab8 Compare May 22, 2024 14:21

zeeke force-pushed the metrics-exporter-test branch from 2e4cab8 to f824a33 Compare May 22, 2024 14:36

zeeke force-pushed the metrics-exporter-test branch from f824a33 to f11ade3 Compare May 22, 2024 15:30

zeeke force-pushed the metrics-exporter-test branch from f11ade3 to 20d2790 Compare May 22, 2024 17:20

zeeke force-pushed the metrics-exporter-test branch from 20d2790 to af25c1b Compare May 22, 2024 17:21

zeeke force-pushed the metrics-exporter-test branch from af25c1b to 9e21801 Compare May 23, 2024 01:51

zeeke force-pushed the metrics-exporter-test branch from 9e21801 to 35b5ded Compare May 23, 2024 12:17

zeeke mentioned this pull request May 23, 2024

[metrics 1/x] Support sriov-network-metrics-exporter #655

Merged

SchSeba reviewed Jun 3, 2024

View reviewed changes

zeeke force-pushed the metrics-exporter-test branch from 35b5ded to a8476f0 Compare July 5, 2024 13:48

zeeke force-pushed the metrics-exporter-test branch from a8476f0 to ae75722 Compare July 5, 2024 13:59

zeeke force-pushed the metrics-exporter-test branch 3 times, most recently from d753fe9 to bd07223 Compare August 5, 2024 11:14

adrianchiris approved these changes Aug 12, 2024

View reviewed changes

zeeke force-pushed the metrics-exporter-test branch from bd07223 to 50e8b8f Compare August 13, 2024 08:49

SchSeba reviewed Aug 19, 2024

View reviewed changes

zeeke force-pushed the metrics-exporter-test branch from 50e8b8f to 5a950b6 Compare August 19, 2024 12:39

SchSeba approved these changes Aug 19, 2024

View reviewed changes

SchSeba merged commit ac35440 into k8snetworkplumbingwg:master Aug 19, 2024
12 of 13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[metrics 3/x] end-to-end tests #702

[metrics 3/x] end-to-end tests #702

zeeke commented May 22, 2024 •

edited

Loading

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

coveralls commented May 22, 2024 •

edited

Loading

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

github-actions bot commented May 23, 2024

github-actions bot commented May 23, 2024

SchSeba Jun 3, 2024

zeeke Jul 5, 2024

SchSeba Jun 3, 2024

zeeke Jul 5, 2024

adrianchiris Aug 12, 2024

zeeke Aug 13, 2024

github-actions bot commented Jul 5, 2024

github-actions bot commented Jul 5, 2024

adrianchiris left a comment

SchSeba Aug 19, 2024

zeeke Aug 19, 2024

SchSeba Aug 19, 2024

zeeke Aug 19, 2024

SchSeba left a comment


		metricsExporterPod := metricsExporterPods.Items[0]

		command := []string{"wget", "-qO-", "http://127.0.0.1:9110/metrics"}

	func pingPod(ip string, nodeSelector string, sriovNetworkAttachment string) {
	ipProtocolVersion := "6"
	if len(strings.Split(ip, ".")) == 4 {
	ipProtocolVersion = "4"
	}
	podDefinition := pod.RedefineWithNodeSelector(
	pod.RedefineWithCapabilities(
	pod.RedefineWithRestartPolicy(
	pod.RedefineWithCommand(
	pod.DefineWithNetworks([]string{sriovNetworkAttachment}),
	[]string{"sh", "-c", fmt.Sprintf("ping -%s -c 3 %s", ipProtocolVersion, ip)}, []string{},
	),
	corev1.RestartPolicyNever,
	),
	[]corev1.Capability{"NET_RAW"},
	),
	nodeSelector,
	)

[metrics 3/x] end-to-end tests #702

[metrics 3/x] end-to-end tests #702

Conversation

zeeke commented May 22, 2024 • edited Loading

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

coveralls commented May 22, 2024 • edited Loading

Pull Request Test Coverage Report for Build 10453520475

Details

💛 - Coveralls

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

github-actions bot commented May 23, 2024

github-actions bot commented May 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jul 5, 2024

github-actions bot commented Jul 5, 2024

adrianchiris left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SchSeba left a comment

Choose a reason for hiding this comment

zeeke commented May 22, 2024 •

edited

Loading

coveralls commented May 22, 2024 •

edited

Loading