Fix config-daemon not waiting for drain to complete #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
pkg/daemon/daemon.go
Outdated
| @@ -484,10 +484,14 @@ func (dn *Daemon) nodeStateSyncHandler() error { | |||
| if reqDrain || !utils.ObjectHasAnnotation(dn.desiredNodeState, | |||
| consts.NodeStateDrainAnnotationCurrent, | |||
| consts.DrainIdle) { | |||
| if err := dn.handleDrain(reqReboot); err != nil { | |||
| shouldReconcile, err := dn.handleDrain(reqReboot) | |||
There was a problem hiding this comment.
can you rename the variable to something like inProgress or drainInProgress? For me shouldReconcile looks more like "should continue the current reconcile cycle", but not like "retry on next reconcile cycle" (the meaning which we want, If I understood correctly)
SchSeba
force-pushed
the
fix_drain_handler
branch
from
425037f to
055f233
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
force-pushed
the
fix_drain_handler
branch
from
055f233 to
07254b5
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Signed-off-by: Sebastian Sch <[email protected]>
Pull Request Test Coverage Report for Build 8720278678Details
💛 - Coveralls |
zeeke
reviewed
Apr 17, 2024
e0ne
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.