Change system dependencies for "post" systemd service #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to be compatible with OVS installations, which use SysV init scripts (wrapped with systemd-sysv-generator). On such systems, OVS may depend on the network-online.target, so the start order of services changes (OVS will start after the "post" service). The proposed solution is to add the following explicit dependencies After: openvswitch-switch.service Before: kubelet.service. Note: the dependency is ignored if the openvswitch-switch.service is not found. Signed-off-by: Yury Kulazhenkov <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 8662475929Details
💛 - Coveralls |
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
We use reenable command (the command is a combination of disable+enable) to reset symlinks for the unit and make sure that only symlinks that are currently configured in the [Install] section exist for the service. Signed-off-by: Yury Kulazhenkov <[email protected]>
ykulazhenkov
force-pushed
the
pr-systemd-service-fix
branch
from
4dc4891 to
359282a
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to be compatible with OVS installations that use SysV init scripts (wrapped with systemd-sysv-generator).
On such systems, OVS depends on the network-online.target, so the start order of services changes (OVS will start after the "post" service). The proposed solution is to add the following explicit dependencies
After: openvswitch-switch.service
Before: kubelet.service.
Note: the dependency is ignored if the openvswitch-switch.service is not found.
cc @e0ne @SchSeba @zeeke