e2e: Debug logging should be visible in multus pod flake
#678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `Pod.Status.StartTime` field to infer the timestamp lower bound of interested log lines. This field is populated by the kubelet, so it uses the same clock as the
multus pod logs.
Prior to this commit, `Meta.CreationTimestamp` field was used. That field is populated
by the API server, which can have a different clock than the kubelet, as they are likely
to run on different nodes.
Following example comes from a CI run:
```
{
"metadata": {
"name": "testpod-68rc4",
"generateName": "testpod-",
"namespace": "sriov-conformance-testing",
"creationTimestamp": "2024-04-08T10:44:45Z",
...
"status": {
...
"startTime": "2024-04-08T10:44:44Z",
}
```
Signed-off-by: Andrea Panattoni <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 8612554667Details
💛 - Coveralls |
SchSeba
approved these changes
Apr 11, 2024
|
@Eoghan1232 @e0ne please take a look for this quick fix |
SchSeba
reviewed
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Pod.Status.StartTimefield to infer the timestamp lower bound of interested log lines. This field is populated by the kubelet, so it uses the same clock as themultus pod logs.
Prior to this commit,
Meta.CreationTimestampfield was used. That field is populatedby the API server, which can have a different clock than the kubelet, as they are likely
to run on different nodes.
Following example comes from a CI run:
2024-04-08T10:44:44Z: