Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow switchdev+externallyManged configs in webhook #675

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Allow switchdev+externallyManged configs in webhook #675

merged 1 commit into from
Apr 24, 2024

Conversation

ykulazhenkov
Copy link
Collaborator

Current implementation supports this combination.
NIC should be already in switchdev mode and have enough VFs to pass checks in the operator.

cc @e0ne @zeeke @SchSeba

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Apr 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8718120638

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 38.455%
Files with Coverage Reduction New Missed Lines %
controllers/drain_controller.go 1 70.36%
controllers/generic_network_controller.go 5 74.53%
Totals Coverage Status
Change from base Build 8707492370: -0.06%
Covered Lines: 4818
Relevant Lines: 12529
💛 - Coveralls

e0ne
e0ne approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a link to commit which implements Current implementation supports this combination if you'll do one more change to this PR

SchSeba
SchSeba reviewed Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add one or two unit tests to cover a validation case
switch dev but no vf, the other way around (both failed ) and one that pass the validation

@ykulazhenkov ykulazhenkov force-pushed the pr-allow-externally-managed-switchdev branch from 9dc733d to 11ccbba Compare April 12, 2024 11:30
@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@ykulazhenkov
Copy link
Collaborator Author

can you please add one or two unit tests to cover a validation case switch dev but no vf, the other way around (both failed ) and one that pass the validation

thanks @SchSeba,
I pushed some tests to validate this behavior

@ykulazhenkov
Allow switchdev+externallyManged configs in webhook
e3ac636 
Current implementation supports this combination.
NIC should be already in switchdev mode and have
enough VFs to pass the check.

Signed-off-by: Yury Kulazhenkov <[email protected]>
@ykulazhenkov ykulazhenkov force-pushed the pr-allow-externally-managed-switchdev branch from 11ccbba to e3ac636 Compare April 17, 2024 07:40
@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

ykulazhenkov
ykulazhenkov commented Apr 17, 2024
View reviewed changes
Copy link
Collaborator Author

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR rebased

@ykulazhenkov
Copy link
Collaborator Author

@SchSeba I rebased the PR and added some tests. PTAL
Thanks

SchSeba
SchSeba approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
nice work!

@SchSeba SchSeba merged commit e741850 into k8snetworkplumbingwg:master Apr 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchSeba SchSeba SchSeba approved these changes

@e0ne e0ne e0ne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykulazhenkov @coveralls @e0ne @SchSeba