Add featuregate package and use it in controllers #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 8534567081Details
💛 - Coveralls |
zeeke
reviewed
Apr 2, 2024
| @@ -58,7 +59,8 @@ const nodePolicySyncEventName = "node-policy-sync-event" | |||
| // SriovNetworkNodePolicyReconciler reconciles a SriovNetworkNodePolicy object | |||
| type SriovNetworkNodePolicyReconciler struct { | |||
| client.Client | |||
| Scheme *runtime.Scheme | |||
| Scheme *runtime.Scheme | |||
| FeatureGate featuregate.FeatureGate | |||
There was a problem hiding this comment.
This field is not used. I guess it will be used in some future PR, right?
There was a problem hiding this comment.
Yes, this is preparation for the next PR.
pkg/featuregate/featuregate.go
Outdated
| // completely removes the previous state | ||
| Init(features map[string]bool) | ||
| // Set state of the specific feature, keeps existing state for other features | ||
| Set(feature string, state bool) |
There was a problem hiding this comment.
Same here, Set seems to be used in tests only. How is it going to be used?
There was a problem hiding this comment.
The Set hadler was added to provide API completeness. There is no real reason to keep it. I will drop it.
There was a problem hiding this comment.
@zeeke I removed Set function
This package is required to simplify usage of feature gates outside of the SriovOperatorConfig controller Signed-off-by: Yury Kulazhenkov <[email protected]>
Use featuregate package in SriovOperatorConfig and in SriovNetworkNodePolicy controllers Signed-off-by: Yury Kulazhenkov <[email protected]>
ykulazhenkov
force-pushed
the
pr-feature-gate
branch
from
7ee5f13 to
3b4bc74
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
@zeeke Can we merge this PR if it looks good for you? thx |
zeeke
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required to simplify usage of feature gates outside of SriovOperatorConfig controller.
SriovOperatorConfig controller is responsible for initialization of the featuregate helper.
Other controllers can check configured feature gates by using the interface.