Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set netdevice as default in the CRD #660

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Set netdevice as default in the CRD #660

merged 1 commit into from
Mar 19, 2024

Conversation

mlguerrero12
Copy link
Contributor

@mlguerrero12 mlguerrero12 commented Mar 18, 2024 •
edited
Loading

This sets netdevice as default in the CRD to not depend on the mutating webhook.

Fixes #629

@mlguerrero12
Set netdevice as default in the CRD
396f122 
This sets netdevice as default in the CRD to not depend
on the mutating webhook.

Fixes k8snetworkplumbingwg#632

Signed-off-by: Marcelo Guerrero <[email protected]>
@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Mar 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8329683973

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 37.73%
Files with Coverage Reduction New Missed Lines %
controllers/drain_controller.go 3 70.68%
Totals Coverage Status
Change from base Build 8324682841: 0.01%
Covered Lines: 4837
Relevant Lines: 12820
💛 - Coveralls

@mlguerrero12 mlguerrero12 reopened this Mar 18, 2024
@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

zeeke
zeeke approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @mlguerrero12

@zeeke zeeke merged commit a496b72 into k8snetworkplumbingwg:master Mar 19, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeke zeeke zeeke approved these changes

@e0ne e0ne e0ne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NeedToUpdateSriov mistakenly fails when webhook is disabled and DeviceType is not set
4 participants
@mlguerrero12 @coveralls @e0ne @zeeke