Add 'IB VF GUID Configuration' design doc #653

almaslennikov · 2024-03-11T16:31:21Z

No description provided.

github-actions · 2024-03-11T16:31:30Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

ykulazhenkov

Thx @almaslennikov.

I added few comments

doc/design/ib-vf-configuration.md

github-actions · 2024-03-13T07:21:01Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-13T07:23:05Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

doc/design/ib-vf-configuration.md

adrianchiris · 2024-03-13T08:33:56Z

doc/design/ib-vf-configuration.md

+it’s proposed not to return an error in this case but assign as many GUIDs as possible.
+To ensure that nothing breaks when users add/remove VFs, the GUID distribution order should always be the same for each individual host.
+
+If there are fewer GUIDs than VFs, then all the GUIDs should be assigned.


we fail in this case ?
or do we randomly generate for the rest ?

if you have 5 GUIDS and 10 VFs, what will be the "other" 5 GUIDs ?

They will be assigned randomly as it's done now. Noted that in the doc

SchSeba · 2024-03-17T12:30:40Z

doc/design/ib-vf-configuration.md

+### Goals
+
+* IB GUID configuration can be read from a static json file on the host
+* IB GUID configuration is static and created in advance


please add per node right as you need unique pkeys in the cluster right?

@almaslennikov did you add this clarification to the design doc ?

doc/design/ib-vf-configuration.md

SchSeba · 2024-03-17T12:34:42Z

doc/design/ib-vf-configuration.md

+
+There can be fewer VFs created than GUIDs. To persist the dynamic nature of the SR-IOV Network operator,
+it’s proposed not to return an error in this case but assign as many GUIDs as possible.
+To ensure that nothing breaks when users add/remove VFs, the GUID distribution order should always be the same for each individual host.


how this will work with the parallel nic configuration that was implemented in the sriov operator?

I believe that if we synchronize the access to the GUID pool, we shouldn't face any issues

please add this one to the test or validation section so we remember to test this :)

Actually, we have changed the impl so that the pool object is immutable. No additional synchronization measures are needed. Tested that on a baremetal cluster

SchSeba · 2024-03-17T12:37:22Z

doc/design/ib-vf-configuration.md

+
+If there are fewer GUIDs than VFs, then all the GUIDs should be assigned.
+
+### Config file


what will be the know location of this file?

I propose to use /var/opt/infiniband_guids. It should be writable across different cloud platforms. Noted that in the doc

we already have folder that is in used by the sriov operator maybe we can use that one and not create another one?

Let's store the file in /etc/sriov-operator/infiniband/guids then

doc/design/ib-vf-configuration.md

github-actions · 2024-03-18T07:02:43Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

ykulazhenkov · 2024-03-20T09:08:30Z

thx, looks good to me

github-actions · 2024-04-16T06:35:50Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

doc/design/ib-vf-configuration.md

github-actions · 2024-04-29T07:23:34Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-04-29T07:29:39Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

adrianchiris

overall looks OK. added a few small comments, once addressed im LGTM

doc/design/ib-vf-configuration.md

github-actions · 2024-05-15T07:01:14Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

doc/design/ib-vf-configuration.md

adrianchiris

one minor nit otherwise lgtm

coveralls · 2024-05-16T13:47:11Z

Pull Request Test Coverage Report for Build 9203390833

Details

0 of 0 changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.02%) to 39.615%

Files with Coverage Reduction	New Missed Lines	%
controllers/drain_controller.go	1	68.06%

Totals
Change from base Build 9203023396:	0.02%
Covered Lines:	5123
Relevant Lines:	12932

💛 - Coveralls

github-actions · 2024-05-21T06:06:31Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke

Left one minor comment. Other than that, LGTM

doc/design/ib-vf-configuration.md

Signed-off-by: amaslennikov <[email protected]>

github-actions · 2024-05-23T06:38:26Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke

LGTM

adrianchiris · 2024-06-05T10:28:14Z

LGTM, merging.

ykulazhenkov reviewed Mar 12, 2024

View reviewed changes

doc/design/ib-vf-configuration.md Show resolved Hide resolved

doc/design/ib-vf-configuration.md Show resolved Hide resolved

doc/design/ib-vf-configuration.md Outdated Show resolved Hide resolved

almaslennikov force-pushed the guid-config-design-doc branch from e69cac9 to 4727e2f Compare March 13, 2024 07:20

almaslennikov force-pushed the guid-config-design-doc branch from 4727e2f to b02243e Compare March 13, 2024 07:22

ykulazhenkov reviewed Mar 13, 2024

View reviewed changes

doc/design/ib-vf-configuration.md Show resolved Hide resolved

adrianchiris reviewed Mar 13, 2024

View reviewed changes

doc/design/ib-vf-configuration.md Show resolved Hide resolved

adrianchiris reviewed Mar 13, 2024

View reviewed changes

SchSeba reviewed Mar 17, 2024

View reviewed changes

almaslennikov force-pushed the guid-config-design-doc branch from b02243e to 9347961 Compare March 18, 2024 07:02

almaslennikov mentioned this pull request Mar 18, 2024

Configure IB VFs' GUIDs using a statically provided GUID pool #659

Merged

ykulazhenkov approved these changes Mar 20, 2024

View reviewed changes

almaslennikov force-pushed the guid-config-design-doc branch from 9347961 to 8da9cce Compare April 16, 2024 06:35

SchSeba reviewed Apr 24, 2024

View reviewed changes

doc/design/ib-vf-configuration.md Outdated Show resolved Hide resolved

almaslennikov force-pushed the guid-config-design-doc branch from 8da9cce to e71fe7d Compare April 29, 2024 07:23

almaslennikov force-pushed the guid-config-design-doc branch from e71fe7d to 854311c Compare April 29, 2024 07:29

adrianchiris reviewed May 13, 2024

View reviewed changes

almaslennikov force-pushed the guid-config-design-doc branch from 854311c to a7c1294 Compare May 15, 2024 07:01

adrianchiris reviewed May 16, 2024

View reviewed changes

doc/design/ib-vf-configuration.md Outdated Show resolved Hide resolved

adrianchiris reviewed May 16, 2024

View reviewed changes

almaslennikov force-pushed the guid-config-design-doc branch from a7c1294 to 93fa079 Compare May 21, 2024 06:06

zeeke reviewed May 21, 2024

View reviewed changes

doc/design/ib-vf-configuration.md Show resolved Hide resolved

Add 'IB VF GUID Configuration' design doc

7ead95e

Signed-off-by: amaslennikov <[email protected]>

almaslennikov force-pushed the guid-config-design-doc branch from 93fa079 to 7ead95e Compare May 23, 2024 06:38

zeeke approved these changes May 23, 2024

View reviewed changes

adrianchiris approved these changes Jun 5, 2024

View reviewed changes

adrianchiris merged commit d0f214e into k8snetworkplumbingwg:master Jun 5, 2024
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 'IB VF GUID Configuration' design doc #653

Add 'IB VF GUID Configuration' design doc #653

almaslennikov commented Mar 11, 2024

github-actions bot commented Mar 11, 2024

ykulazhenkov left a comment

github-actions bot commented Mar 13, 2024

github-actions bot commented Mar 13, 2024

adrianchiris Mar 13, 2024

almaslennikov Mar 18, 2024

SchSeba Mar 17, 2024

adrianchiris May 16, 2024

SchSeba Mar 17, 2024

almaslennikov Mar 18, 2024

SchSeba Mar 31, 2024

almaslennikov Apr 16, 2024

SchSeba Mar 17, 2024

almaslennikov Mar 18, 2024

SchSeba Mar 31, 2024

almaslennikov Apr 16, 2024

github-actions bot commented Mar 18, 2024

ykulazhenkov commented Mar 20, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

adrianchiris left a comment

github-actions bot commented May 15, 2024

adrianchiris left a comment

coveralls commented May 16, 2024 •

edited

Loading

github-actions bot commented May 21, 2024

zeeke left a comment

github-actions bot commented May 23, 2024

zeeke left a comment

adrianchiris commented Jun 5, 2024


		If there are fewer GUIDs than VFs, then all the GUIDs should be assigned.

		### Config file

Add 'IB VF GUID Configuration' design doc #653

Add 'IB VF GUID Configuration' design doc #653

Conversation

almaslennikov commented Mar 11, 2024

github-actions bot commented Mar 11, 2024

ykulazhenkov left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 13, 2024

github-actions bot commented Mar 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Mar 18, 2024

ykulazhenkov commented Mar 20, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

adrianchiris left a comment

Choose a reason for hiding this comment

github-actions bot commented May 15, 2024

adrianchiris left a comment

Choose a reason for hiding this comment

coveralls commented May 16, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9203390833

Details

💛 - Coveralls

github-actions bot commented May 21, 2024

zeeke left a comment

Choose a reason for hiding this comment

github-actions bot commented May 23, 2024

zeeke left a comment

Choose a reason for hiding this comment

adrianchiris commented Jun 5, 2024

coveralls commented May 16, 2024 •

edited

Loading