Remove bool ptr

[adrianchiris]

Change boolean attribute in SriovOperatorConfig from pointer to concrete.
Main motivation is to simplify code a bit

[github-actions]

Thanks for your PR,
To run vendors CIs use one of:

• /test-all: To run all tests for all vendors.
• /test-e2e-all: To run all E2E tests for all vendors.
• /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

• /skip-all: To skip all tests for all vendors.
• /skip-e2e-all: To skip all E2E tests for all vendors.
• /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
  Best regards.

[coveralls]

Pull Request Test Coverage Report for Build 7816545048

• -2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
• 6 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.08%) to 25.785%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
controllers/sriovoperatorconfig_controller.go	2	4	50.0%

Files with Coverage Reduction	New Missed Lines	%
controllers/sriovoperatorconfig_controller.go	6	54.89%

Totals
Change from base Build 7801115751:	-0.08%
Covered Lines:	2898
Relevant Lines:	11239

---

💛 - Coveralls

[e0ne]

LGTM. Thanks for making our code more simple

[adrianchiris]

@SchSeba could you take a look, this is a short one.

[SchSeba]

general question this will mean that it will be false by default so if someone create the sriovOperatorConfig without this fields it will be false and in case of a pointer it will not exist no?

[adrianchiris]

general question this will mean that it will be false by default so if someone create the sriovOperatorConfig without this fields it will be false and in case of a pointer it will not exist no?

yes, but we have no use-case for a "missing" value.
moreover we always create the default config with values set today.

[SchSeba]

yep you are right I have no problem moving this one out of a pointer and if in the future this is needed we can revert it. from the CRD point of view there is no change so it's transparent to the user