[Remove Default Objs 2/4] Set OwnerReference to default SriovOperatorConfig
#621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 7957326875Details
💛 - Coveralls |
|
Related to: #592 |
adrianchiris
force-pushed
the
set-owner-ref-to-config
branch
from
249ad4b to
2216e2b
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
adrianchiris
changed the title
default SriovOperatorConfigdefault SriovOperatorConfig
Use default SriovOperatorConfig object instead of default SriovNetworkNodePolicy. This change is required as subsequent changes will drop the creation of the default policy. Signed-off-by: adrianc <[email protected]>
change SriovNetworkNodeState OwnerReference to point to the "default" SriovOperatorConfig as the current owner (default SriovNetworkNodePolicy) is going to be removed in subsequent commit Signed-off-by: adrianc <[email protected]>
adrianchiris
force-pushed
the
set-owner-ref-to-config
branch
from
2216e2b to
5b1bdda
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are deprecating the use of the default SriovNetworkNodePolicy.
This PR changes the OwnerReference of sriov-network-device-plugin and SriovNetworkNodePolicy which are created
by the operator to point to the default SriovOperatorConfig CR.
This PR depends on #617 Only the last 2 commits are related (the rest will be rebased away once #617 merges)