Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in mellanox plugin name in logs #615

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

ykulazhenkov
Copy link
Collaborator

mellalnox > mellanox

@adrianchiris

Signed-off-by: Yury Kulazhenkov <[email protected]>
Copy link

github-actions bot commented Feb 2, 2024

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7759695416

  • -2 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 25.867%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/plugins/mellanox/mellanox_plugin.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 68.94%
api/v1/helper.go 3 42.68%
Totals Coverage Status
Change from base Build 7754000139: -0.05%
Covered Lines: 2908
Relevant Lines: 11242

💛 - Coveralls

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeeke zeeke merged commit c0bf46c into k8snetworkplumbingwg:master Feb 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants